Feat: Add username, password to Pinot Connection#46826
Merged
jscheffl merged 4 commits intoapache:mainfrom Mar 8, 2025
Merged
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
p-eye
changed the title
potiuk
approved these changes
Feb 17, 2025
p-eye
force-pushed
the
feature/add-user-pwd-to-pinotconn
branch
from
a140da0 to
1f0f9ab
Compare
Contributor
Author
|
it passed the pre-commit and breeze test. |
Member
|
regular tests fail now. |
p-eye
requested review from
Fokko,
XD-DENG,
ashb,
bbovenzi,
bolkedebruin,
dstandish,
eladkal,
ephraimbuddy,
hussein-awala,
jedcunningham,
josh-fell,
jscheffl,
mik-laj,
mobuchowski,
o-nikolas,
pierrejeambrun and
ryanahamilton
as code owners
p-eye
force-pushed
the
feature/add-user-pwd-to-pinotconn
branch
from
a8e579e to
1f0f9ab
Compare
…rflow UI connection behavior) test: set login/password as empty string not to return mock
Contributor
Author
|
jscheffl
approved these changes
Mar 8, 2025
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
67 tasks
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
Apr 4, 2025
* feat: add username, password to Pinot Connection * fix: rename params conn.user to conn.login to align with Airflow Connection * fix: don't add login/password to PinotCLI if None or empty string (Airflow UI connection behavior) test: set login/password as empty string not to return mock
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background:
The
PinotDbApiHookandPinotAdminHookwere previously not handling authentication properly when connecting to a secured Pinot cluster. In scenarios where authentication was required, the hooks would fail to pass login and password details, leading to connection and query failures.Changes:
PinotDbApiHook:
PinotDbApiHookto support authentication for both connection and query execution.loginandpasswordfields from the connection parameters to properly construct the connection URI and ensure authentication when connecting to the Pinot cluster.PinotAdminHook:
PinotAdminHookto handle authentication when running Pinot Admin CLI commands.-userand-passwordflags, using the credentials from the connection object.Test Cases:
PinotDbApiHookandPinotAdminHookto verify the authentication logic:PinotDbApiHook, tests ensure thatloginandpasswordare correctly used to generate the connection URI.PinotAdminHook, a test was added to verify that authentication details are passed to the CLI when running theadd_schemacommand, for example.Impact:
PinotDbApiHookandPinotAdminHookhas been improved, ensuring that the hooks can now properly authenticate with Pinot clusters requiring login and password.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.